adjust benchmark close to real-life usage #1537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lifeart
force-pushed
the
adjust-benchmark
branch
12 times, most recently
from
c6a826e to
07a522b
Compare
attempt to fix GC reduce memory pressure
lifeart
force-pushed
the
adjust-benchmark
branch
from
07a522b to
d816102
Compare
NullVoxPopuli
approved these changes
Dec 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Referencing to https://github.com/krausest/js-framework-benchmark/blob/master/frameworks/keyed/ember/app/components/my-table.gjs
In short, I think it's good to use as many as possible glimmer-opcodes in benchmark.
Updated implementation includes
...attributesopcode, additionalconcatstatement for class,fnandeqhelper usage to improve DX (storing UI state outside of data models).I don't think that we need to have
very fastbenchmark, because it's not target for us.It may be slower comparing to
krausestimplementation, but should use most common patterns across ecosystem and highlight performance problems for it (example: #1321).10k case reduced to 5k to reduce memory pressure (really bad on CI)
Throttle increased to 4 from 2 to increase resolution on relatively fast tasks (row select, row removal)
artifact-1.pdf