[CLEANUP] Drop support for {{#with}} keyword
#1574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was dropped on Ember side a while back, just never cleaned up
Ironically this probably meant when Ember dropped the deprecation/
error, nothing was actually stopping `{{#with}}` from anymore, so
perhaps for a while we have actually _re-introduced_ support for
the syntax for some time?
Extracted from #1557
Yeah,I think we actually did, just tried in on 5.4 and Specifically, in here: emberjs/ember.js#19632 / emberjs/ember.js#19638 This is partially why, among other reasons, when removing a deprecated feature, we typically want to swap the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was dropped on Ember side a while back, just never cleaned up
Ironically this probably meant when Ember dropped the deprecation/ error, nothing was actually stopping
{{#with}}from anymore, so perhaps for a while we have actually re-introduced support for the syntax for some time?Extracted from #1557