Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix component hooks #304

Merged
merged 3 commits into from
Sep 7, 2016
Merged

Fix component hooks #304

merged 3 commits into from
Sep 7, 2016

Conversation

chancancode
Copy link
Contributor

@chancancode chancancode commented Sep 7, 2016 •
edited
Loading

This is required to fix component hooks in Ember:

  1. ComponentManager#{update,didUpdate} always fire when re-rendering a subtree (see [Glimmer 2] Difference in willRender semantics emberjs/ember.js#13947)
  2. Async hooks are queued and executed in "post-order": firstChild -> secondChild -> lastChild -> parent (see call order for didInsertElement for siblings reversed emberjs/ember.js#13972)

@chancancode chancancode mentioned this pull request Sep 7, 2016
Merged
@chancancode
Call super with the right arguments
ca4d8ed
@chancancode
Always fire update hooks
172383e 
This is to align the semantics with emberjs/ember.js#13947

Currently these things are tested in Ember, but we need to port those
tests over soon.
@chancancode
Make didCreate and didUpdate post-order
fb5c83e 
See emberjs/ember.js#13972
@rwjblue rwjblue merged commit 57fc932 into master Sep 7, 2016
@rwjblue rwjblue deleted the fix-component-hooks branch September 7, 2016 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chancancode @rwjblue