Ensure custom element fallback properly specializes statements. #529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The root cause of the various `implementation missing for: x` errors is that the custom element fallback was using unspecialized opcodes that are not used/tested through the rest of the system (since we generally use the specialized versions if at all possible). This fixes the issue by specializing inside the fallback branch. A joint @krisselden / @rwjblue production.
This was referenced May 30, 2017
This was referenced Jun 4, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The root cause of the various
implementation missing for: xerrors is that the custom element fallback was using unspecialized opcodes that are not used/tested through the rest of the system (since we generally use the specialized versions if at all possible).This fixes the issue by specializing inside the fallback branch.
A joint @krisselden / @rwjblue production.
Fixes #511
Fixes #494
Fixes #493
Replaces #488