Fix path lookup inside helpers #707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…biguous cases MustacheExpressions generate a `get` opcode in cases where the identifier is statically found in their scope, but fall back to `maybeLocal` otherwise to disambiguate at compile time whether they are being invoked inside a partial or not. PathExpressions however did not go through this path, always using a `get` opcode even in cases that were ambiguous. This caused any PathExpression inside a partial to fail when inheriting an identifier from the outside scope. This commit changes the PathExpression compiler to generate a `maybeLocal` opcode in the ambiguous case instead of a `get`.
|
Looks good to me. As far as I can tell, we just forgot to do it in 702d1de |
|
This change seems to have caused a regression in the Ember test suite: emberjs/ember.js#15777 (comment) (with the v0.25.4 release)
|
|
@GavinJoyce The regression was fixed on the Ember.js side in emberjs/ember.js#15777, right, and there is nothing we need to do on the Glimmer VM side? |
|
@tomdale yes, this was fixed in Ember in emberjs/ember.js#15777 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #705
MustacheExpressions generate a
getopcode in cases where the identifier is statically found in their scope, but fall back tomaybeLocalotherwise to disambiguate at compile time whether they are being invoked inside a partial or not.PathExpressions however did not go through this path, always using a
getopcode even in cases that were ambiguous. This caused any PathExpression inside a partial to fail when inheriting an identifier from the outside scope.This PR changes the PathExpression compiler to generate a
maybeLocalopcode in the ambiguous case instead of aget.