[FEAT] Perf Tuning + Functional API #964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds the perf tuning and functional API changes made in the 0.38 release to master.
pzuraq
force-pushed
the
feature/validator-perf-tuning-functional-api
branch
from
c3bf720 to
cb2c963
Compare
rwjblue
reviewed
Aug 13, 2019
| @@ -87,6 +87,10 @@ | |||
| "tslint-config-prettier": "^1.15.0", | |||
| "tslint-plugin-prettier": "^2.0.1" | |||
| }, | |||
| "resolutions": { | |||
There was a problem hiding this comment.
Why do we need these resolutions? When can we remove them (maybe make an issue to track that)?
There was a problem hiding this comment.
TypeScript doesn’t allow us to cast any to type unique symbol until more recently, and its the only way we can polyfill Symbol and type it correctly. We should likely update to the latest TS when possible (brocolli-typescript-transpiler needs to update). There are some other breaking changes on latest though
There was a problem hiding this comment.
I think #946 kind of tracks this
rwjblue
approved these changes
Aug 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the perf tuning and functional API changes made in the 0.38
release to master, from #963