Select: Clean up some warnings

glints-dev · Apr 8, 2021 · bed9227 · bed9227
1 parent 449c300
commit bed9227
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/src/Input/DownshiftSelect/Select.stories.tsx b/src/Input/DownshiftSelect/Select.stories.tsx
@@ -333,6 +333,7 @@ export const ControlledInputValue: Story<Props> = () => {
         <TextField
           value={inputValue}
           onChange={(e: any) => setInputValue(e.target.value)}
+          placeholder="foo"
         />
       </Box>
       <Box mb={8}>

diff --git a/src/Input/DownshiftSelect/Select.tsx b/src/Input/DownshiftSelect/Select.tsx
@@ -291,11 +291,11 @@ export const Select: React.FC<Props> & { Components: Components } = ({
           {...getInputProps({
             disabled: disabled,
             readOnly: disableTyping,
+            placeholder: placeholder,
             onFocus,
             onBlur,
             ...props,
           })}
-          placeholder={placeholder}
           aria-invalid={invalid}
           {...(helperText && { 'aria-describedby': helperId })}
           {...(selectedItem && { title: selectedItem.label })}
@@ -321,6 +321,7 @@ export const Select: React.FC<Props> & { Components: Components } = ({
             })}
             aria-label="toggle menu"
             data-testid="toggle-button"
+            ref={undefined}
           >
             {isOpen ? <ArrowUpIcon /> : <ArrowDownIcon />}
           </ToggleButton>