Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add role badges to WebUI #2096

Merged

Conversation

ClearlyClaire
Copy link

@ClearlyClaire ClearlyClaire commented Jan 26, 2023

Port of mastodon#21393 to glitch-soc

image

Signed-off-by: Claire <claire.github-309c@sitedethib.com>
Signed-off-by: Claire <claire.github-309c@sitedethib.com>
@ClearlyClaire ClearlyClaire marked this pull request as ready for review January 26, 2023 20:44
Copy link

@Plastikmensch Plastikmensch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like the role badge being under the avatar, but I think it somewhat clashes design-wise with the bot badge if present.
It's not too useful to give bots a role, but I have seen admin accounts with bot labels in the wild before (Whether they have a role or not I can't tell).
But I also don't like the wasted space of the other proposal upstream and while the role badge could also be shown in the header, it looks better as is now and works better with long display names.

@ClearlyClaire
Copy link
Author

This is how it looks with the bot badge:
image

It's not ideal but it works.

@ClearlyClaire ClearlyClaire merged commit d9a078e into glitch-soc:main Jan 26, 2023
@Plastikmensch
Copy link

Plastikmensch commented Jan 26, 2023

This is how it looks with the bot badge:
image

It's not ideal but it works.

Yeah, I experimented with displaying the bot badge as an overlay on the avatar, which also makes it possible to show it in timelines, but I think it would clash even more with this.
Another idea would be to move the bot badge to the same place as the role badge, but only one could be shown in that case, which also isn't ideal.
I don't have a good solution for that.

btw this should close #2073

@jippi
Copy link

jippi commented Jan 28, 2023

Thank you ❤️

ClearlyClaire added a commit that referenced this pull request Jan 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants