Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port UI focus changes from upstream #2350

Closed
wants to merge 6 commits into from
Closed

Port UI focus changes from upstream #2350

wants to merge 6 commits into from

Conversation

Plastikmensch
Copy link

@Plastikmensch Plastikmensch commented Jul 31, 2023 •
edited
Loading

Closes #2342

TODO:

Notes:

  • Glitch-soc already has focus styling for drawer__header. I'm inclined to keep that.
  • Keyboard navigation doesn't really work well with collapsed toots (try navigating a collapsed poll notification). Not sure how to address that yet.
  • Compared to upstream more outlines are cut off. Likely caused by different wrapping of elements.
  • Not sure removing the outline on the "Show more" button is a good call, but it matches upstream.

Also present upstream:

  • Poll refresh button has different outline
  • notification filter bar has different outline

@Plastikmensch
[Glitch] change focus ui for keyboard only input
0d2e566 
Port 59478a1 to glitch-soc

Signed-off-by: Plastikmensch <plastikmensch@users.noreply.github.com>
@Plastikmensch
[Glitch] Fix focus and hover styles in web UI
47507f2 
Port cfd50f3 to glitch-soc

Signed-off-by: Plastikmensch <plastikmensch@users.noreply.github.com>
@Plastikmensch
Fix tabindex for status content
235ce14 
Glitch-soc wraps toots differently, which caused toot content to be focusable twice.

This brings the component closer to upstream.

Signed-off-by: Plastikmensch <plastikmensch@users.noreply.github.com>
@Plastikmensch
Make back button outline match upstream
77ac778 
Glitch-soc has column headers where upstream doesn't, causing inconsistency with the outline.

Signed-off-by: Plastikmensch <plastikmensch@users.noreply.github.com>
@Plastikmensch
Remove outline on "Show more" button
6b9c46a 
Signed-off-by: Plastikmensch <plastikmensch@users.noreply.github.com>
@Plastikmensch
Remove semi-transparent outline from mascot
f0a2242 
Signed-off-by: Plastikmensch <plastikmensch@users.noreply.github.com>
@Plastikmensch
Copy link
Author

This should be good.

Noticed some issues with local setting regarding focus.
Changes for that have been split out into separate PRs.

@Plastikmensch Plastikmensch changed the title [WIP] Port UI focus changes from upstream Port UI focus changes from upstream Aug 1, 2023
@Plastikmensch Plastikmensch marked this pull request as ready for review August 1, 2023 17:25
@github-actions
Copy link

This pull request has merge conflicts that must be resolved before it can be merged.

@Plastikmensch
Copy link
Author

See: #2365 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
rebase needed 🚧
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Port UI focus behavior/styling changes from upstream
1 participant
@Plastikmensch