Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge upstream changes up to 6273416292090b2f6bfda33f070cea325a1759df #2406

Merged
merged 86 commits into from
Sep 16, 2023

Conversation

ClearlyClaire
Copy link

@ClearlyClaire ClearlyClaire commented Sep 15, 2023

Fixes #2405

Merge upstream changes up to 548c032

Conflicts

None

Ported changes

Merge upstream changes up to 93d051e

Conflicts

None

Ported changes

Postponed changes

Merge upstream changes up to 398635c

Conflicts

None

Ported changes

Skipped changes

  • 398635c (we have a pretty different design and don't have this issue)

Merge upstream changes up to b1d8907

Conflicts

None

Ported changes

Merge upstream changes up to 97e4011

Conflicts

  • config/initializers/content_security_policy.rb:
    Upstream added some code to add the Identity Provider's sign-in endpoint to the form-action Content Security Policy directive but our version of the file is pretty different.
    Ported the change.

Ported changes

Postponed changes (see #2408)

Merge upstream changes up to b90383d (v4.2.0-rc1)

No conflicts and nothing to port

Merge upstream changes up to 6273416

Conflicts

  • .github/workflows/build-nightly.yml:
    Upstream modified this file close to a line modified by glitch-soc to disable the ARMv64 builder (as glitch-soc doesn't have one).
    Ported upstream's changes.
  • .github/workflows/build-releases.yml:
    Upstream modified this file close to lines changed by glitch-soc to change the Docker image repositories used (only ghcr, and based on the organization's name).
    Ported upstream's changes.

Ported changes

Additional changes

ClearlyClaire and others added 30 commits September 5, 2023 23:49
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…face (mastodon#26724)

Co-authored-by: Claire <claire.github-309c@sitedethib.com>
Co-authored-by: Jeong Arm <kjwonmail@gmail.com>
Co-authored-by: Eugen Rochko <eugen@zeonfederated.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@ClearlyClaire ClearlyClaire force-pushed the glitch-soc/merge-upstream branch from ec5341d to 526f457 Compare September 15, 2023 18:54
ClearlyClaire and others added 13 commits September 15, 2023 20:57
…n search popout

Port 9c1ef83 to glitch-soc

Signed-off-by: Claire <claire.github-309c@sitedethib.com>
Port 1f141f6 to glitch-soc

Signed-off-by: Claire <claire.github-309c@sitedethib.com>
…b UI

Port f3a2e15 to glitch-soc

Signed-off-by: Claire <claire.github-309c@sitedethib.com>
…eb UI

Port 91040da to glitch-soc

Signed-off-by: Claire <claire.github-309c@sitedethib.com>
Port 9b2bc3d to glitch-soc

Signed-off-by: Claire <claire.github-309c@sitedethib.com>
…oc/merge-upstream

Conflicts:
- `config/initializers/content_security_policy.rb`:
  Upstream added some code to add the Identity Provider's sign-in endpoint to
  the `form-action` Content Security Policy directive but our version of the
  file is pretty different.
  Ported the change.
Port d2cfcdd to glitch-soc

Signed-off-by: Claire <claire.github-309c@sitedethib.com>
…er login

Port 520b570 to glitch-soc

Signed-off-by: Claire <claire.github-309c@sitedethib.com>
…oc/merge-upstream

Conflicts:
- `.github/workflows/build-nightly.yml`:
  Upstream modified this file close to a line modified by glitch-soc to
  disable the ARMv64 builder (as glitch-soc doesn't have one).
  Ported upstream's changes.
- `.github/workflows/build-releases.yml`:
  Upstream modified this file close to lines changed by glitch-soc to
  change the Docker image repositories used (only ghcr, and based on the
  organization's name).
  Ported upstream's changes.
Port 2a4fcc5 to glitch-soc

Signed-off-by: Claire <claire.github-309c@sitedethib.com>
@ClearlyClaire ClearlyClaire marked this pull request as ready for review September 15, 2023 20:32
Copy link

@Plastikmensch Plastikmensch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, missed that while triaging but I don't like that 5d20733
also changes the background for the notification bar and tabs on account pages:

Before:
Notification filter bar using darker background
Profile page tabs using darker background

After:
Notification filter bar using same background as other elements
Profile page tabs use same background as other elements

I can't tell if that's an oversight or on purpose though, it just looks off to me.

Just wanted to note that, otherwise the changes look good to me.

@ClearlyClaire
Copy link
Author

This is a change made on purpose upstream, but I do agree this makes tabs more difficult to visually distinguish from the contents.

@ClearlyClaire
Copy link
Author

Reverted the background color

@ClearlyClaire ClearlyClaire changed the title Merge upstream changes Merge upstream changes up to 6273416292090b2f6bfda33f070cea325a1759df Sep 16, 2023
@ClearlyClaire ClearlyClaire merged commit 743fede into glitch-soc:main Sep 16, 2023
@Plastikmensch
Copy link

Thank you!

@Plastikmensch
Copy link

Ah, sorry, I usually don't check locales, but upstream has removed suggestions.dismiss, but it is still used in app/javascript/flavours/glitch/features/directory/components/account_card.jsx to dismiss account suggestions in explore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When OMNIAUTH_ONLY=true the web interface stuck and cannot log in v4.2.0