Remove deprected custom data keys (#5954)

Co-authored-by: Ruben <vandervalk@geoit.nl>
global-121 · Oct 23, 2024 · 6da16e3 · 6da16e3
1 parent dbae23c
commit 6da16e3
Show file tree

Hide file tree

Showing 4 changed files with 19 additions and 9 deletions.
diff --git a/services/121-service/src/migration/1729602981695-deprecated-custom-data-key.ts b/services/121-service/src/migration/1729602981695-deprecated-custom-data-key.ts
@@ -0,0 +1,19 @@
+import { MigrationInterface, QueryRunner } from 'typeorm';
+
+export class DeprecatedCustomDataKey1729602981695
+  implements MigrationInterface
+{
+  name = 'DeprecatedCustomDataKey1729602981695';
+
+  public async up(queryRunner: QueryRunner): Promise<void> {
+    await queryRunner.query(
+      `ALTER TABLE "121-service"."program" DROP COLUMN "deprecatedCustomDataKeys"`,
+    );
+  }
+
+  public async down(queryRunner: QueryRunner): Promise<void> {
+    await queryRunner.query(
+      `ALTER TABLE "121-service"."program" ADD "deprecatedCustomDataKeys" json NOT NULL DEFAULT '[]'`,
+    );
+  }
+}
diff --git a/services/121-service/src/programs/program.entity.ts b/services/121-service/src/programs/program.entity.ts
@@ -112,12 +112,6 @@ export class ProgramEntity extends CascadeDeleteEntity {
   @OneToMany(() => RegistrationEntity, (registrations) => registrations.program)
   public registrations: Relation<RegistrationEntity[]>;
 
-  // Can be used to add deprecated custom attributes to an export if
-  @Column('json', {
-    default: [],
-  })
-  public deprecatedCustomDataKeys: unknown[];
-
   @Column({ default: false })
   public tryWhatsAppFirst: boolean;
 

diff --git a/services/121-service/test/program/__snapshots__/create-fsp-configuration.test.ts.snap b/services/121-service/test/program/__snapshots__/create-fsp-configuration.test.ts.snap
@@ -8,7 +8,6 @@ exports[`Create program questions should create a program with FSP configuration
   "allowEmptyPhoneNumber": false,
   "budget": null,
   "currency": "EUR",
-  "deprecatedCustomDataKeys": [],
   "description": {
     "en": "",
   },

diff --git a/services/121-service/test/program/__snapshots__/create-program.test.ts.snap b/services/121-service/test/program/__snapshots__/create-program.test.ts.snap
@@ -8,7 +8,6 @@ exports[`Create program should post a program: Create program response for progr
   "allowEmptyPhoneNumber": false,
   "budget": null,
   "currency": "ETB",
-  "deprecatedCustomDataKeys": [],
   "description": {
     "en": "",
   },
@@ -1071,7 +1070,6 @@ exports[`Create program should post a program: Create program response for progr
   "allowEmptyPhoneNumber": false,
   "budget": null,
   "currency": "EUR",
-  "deprecatedCustomDataKeys": [],
   "description": {
     "en": "",
   },