Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Enforce best-practices in e-mail contents, to prevent training users to be vulnerable for phishing-attacks #5935

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

elwinschmitz
Copy link
Member

@elwinschmitz elwinschmitz commented Oct 21, 2024

  • Use fully visible, plain URLs so users can copy-paste or "type them over", instead of blindly clicking-whats-there
  • Improve styling of password to prevent misspellings/typos
  • (auto-)fix formatting to prevent long, unreadable lines of code
  • Use single place for template + styling (instead of multiple + in Azure Logic-app config)

AB#30828

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have added tests wherever relevant
  • I have made sure that all automated checks pass before requesting a review
  • I do not need any deviation from our PR guidelines

@elwinschmitz elwinschmitz added the chore Something that does not affect the end user label Oct 21, 2024
@elwinschmitz elwinschmitz marked this pull request as ready for review October 21, 2024 09:30
RubenGeo
RubenGeo previously approved these changes Oct 22, 2024
…sers to be vulnerable for phishing-attacks

- Use fully visible, plain URLs so users can copy-paste or "type them over", instead of blindly clicking-whats-there
- Improve styling of password to prevent misspellings/typos
- (auto-)fix formatting to prevent long, unreadable lines of code
- Use single place for template + styling (instead of multiple + in Azure Logic-app config)
@elwinschmitz elwinschmitz merged commit 62a836a into main Oct 23, 2024
6 checks passed
@elwinschmitz elwinschmitz deleted the elwin/fix/emails branch October 23, 2024 16:04
tijsziere pushed a commit that referenced this pull request Oct 24, 2024
…sers to be vulnerable for phishing-attacks (#5935)

- Use fully visible, plain URLs so users can copy-paste or "type them over", instead of blindly clicking-whats-there
- Improve styling of password to prevent misspellings/typos
- (auto-)fix formatting to prevent long, unreadable lines of code
- Use single place for template + styling (instead of multiple + in Azure Logic-app config)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Something that does not affect the end user
Development

Successfully merging this pull request may close these issues.

2 participants