Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprected custom data keys #5954

Merged
merged 2 commits into from
Oct 23, 2024
Merged

Remove deprected custom data keys #5954

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3d25cf2
Remove deprected custom data keys
Oct 22, 2024
9af0aa4
Merge branch 'main' into chore.remove-deprecated-custom-data-keys
jannisvisser Oct 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions services/121-service/src/migration/1729602981695-deprecated-custom-data-key.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
import { MigrationInterface, QueryRunner } from 'typeorm';

export class DeprecatedCustomDataKey1729602981695
implements MigrationInterface
{
name = 'DeprecatedCustomDataKey1729602981695';

public async up(queryRunner: QueryRunner): Promise<void> {
await queryRunner.query(
`ALTER TABLE "121-service"."program" DROP COLUMN "deprecatedCustomDataKeys"`,
);
}

public async down(queryRunner: QueryRunner): Promise<void> {
await queryRunner.query(
`ALTER TABLE "121-service"."program" ADD "deprecatedCustomDataKeys" json NOT NULL DEFAULT '[]'`,
);
}
}
6 changes: 0 additions & 6 deletions services/121-service/src/programs/program.entity.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,12 +112,6 @@ export class ProgramEntity extends CascadeDeleteEntity {
@OneToMany(() => RegistrationEntity, (registrations) => registrations.program)
public registrations: Relation<RegistrationEntity[]>;

// Can be used to add deprecated custom attributes to an export if
@Column('json', {
default: [],
})
public deprecatedCustomDataKeys: unknown[];

@Column({ default: false })
public tryWhatsAppFirst: boolean;

Expand Down
1 change: 0 additions & 1 deletion services/121-service/test/program/__snapshots__/create-fsp-configuration.test.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ exports[`Create program questions should create a program with FSP configuration
"allowEmptyPhoneNumber": false,
"budget": null,
"currency": "EUR",
"deprecatedCustomDataKeys": [],
"description": {
"en": "",
},
Expand Down
2 changes: 0 additions & 2 deletions services/121-service/test/program/__snapshots__/create-program.test.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ exports[`Create program should post a program: Create program response for progr
"allowEmptyPhoneNumber": false,
"budget": null,
"currency": "ETB",
"deprecatedCustomDataKeys": [],
"description": {
"en": "",
},
Expand Down Expand Up @@ -1071,7 +1070,6 @@ exports[`Create program should post a program: Create program response for progr
"allowEmptyPhoneNumber": false,
"budget": null,
"currency": "EUR",
"deprecatedCustomDataKeys": [],
"description": {
"en": "",
},
Expand Down
Loading