Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add forbidden and unautherized to all endpoint swagger docs #5990

Merged
merged 3 commits into from
Oct 30, 2024
Merged

Add forbidden and unautherized to all endpoint swagger docs #5990

merged 3 commits into from
Oct 30, 2024

Conversation

RubenGeo
Copy link
Contributor

@RubenGeo RubenGeo commented Oct 28, 2024 •
edited
Loading

AB#30959

Describe your changes

Add forbidden and unauth http codes to all swagger endpoints

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have added tests wherever relevant
  • I have made sure that all automated checks pass before requesting a review
  • I do not need any deviation from our PR guidelines

@RubenGeo RubenGeo added Refactor registration data PRs part of item AB#28961 to refactor registration data chore Something that does not affect the end user labels Oct 28, 2024
@RubenGeo RubenGeo enabled auto-merge (squash) October 28, 2024 10:49
diderikvw
diderikvw reviewed Oct 28, 2024
View reviewed changes
Copy link
Contributor

@diderikvw diderikvw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice refactor. See comment.

services/121-service/src/guards/authenticated-user.decorator.ts Show resolved Hide resolved
diderikvw
diderikvw requested changes Oct 29, 2024
View reviewed changes
Copy link
Contributor

@diderikvw diderikvw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment.

services/121-service/src/guards/authenticated-user.decorator.ts Show resolved Hide resolved
@diderikvw diderikvw force-pushed the chore.forbidden-response-swagger-doc branch from 2cd1b28 to b08ccae Compare October 30, 2024 14:50
@RubenGeo RubenGeo merged commit d4f593a into main Oct 30, 2024
6 checks passed
@RubenGeo RubenGeo deleted the chore.forbidden-response-swagger-doc branch October 30, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diderikvw diderikvw diderikvw approved these changes

Assignees
No one assigned
Labels
chore Something that does not affect the end user Refactor registration data PRs part of item AB#28961 to refactor registration data
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RubenGeo @diderikvw