Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: put export-type enum in separate file #5999

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

aberonni
Copy link
Contributor

@aberonni aberonni commented Oct 29, 2024

AB#31009

To be able to use ExportType enum easily in Portalicious, we need to separate it into a file of its own. This should be in line with the 121-service guidelines so it shouldn't be an issue, and is worth the refactor on its own IMHO.

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have added tests wherever relevant
  • I have made sure that all automated checks pass before requesting a review
  • I do not need any deviation from our PR guidelines

@aberonni aberonni added the chore Something that does not affect the end user label Oct 29, 2024
@jannisvisser
Copy link
Contributor

@aberonni I constantly see 'this change is out of date with main branch', which then prevents being able to merge (or auto-merge from materializing). You have to click 'update branch' then. But if it's not being merged, and then another PR is merged into main, you have to do it again. Is this just how it is?

@aberonni
Copy link
Contributor Author

@jannisvisser

Is this just how it is?

Pretty much so, yes. It's because of this setting that we enabled a while ago when introducing the PR guidelines:
image

So if you're in the midst of "PR merging traffic" then you'll have to update the branch a few times before it gets merged.

But tbh, I most of the time leave it to the author to make sure it gets merged.

That said,

You have to click 'update branch' then.

doing that on behalf of the author is fine, but then I would make sure you use the dropdown to select "Update with rebase" rather than update with merge. (It would be great if this could be the default but alas that is not possible).

@aberonni aberonni enabled auto-merge (squash) October 30, 2024 08:31
AB#31009

To be able to use ExportType enum easily in Portalicious, we need to separate it into a file of its own. This should be in line with the 121-service guidelines so it shouldn't be an issue, and is worth the refactor on its own IMHO.
@aberonni aberonni force-pushed the aberonni/refactor-export-type-enum branch from 8165fc0 to 9d5d96b Compare October 30, 2024 08:40
@aberonni aberonni merged commit cf0def4 into main Oct 30, 2024
6 checks passed
@aberonni aberonni deleted the aberonni/refactor-export-type-enum branch October 30, 2024 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Something that does not affect the end user
Development

Successfully merging this pull request may close these issues.

2 participants