Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: api-tests on update chosen fsp AB#31025 #6006

Merged

Conversation

jannisvisser
Copy link
Contributor

@jannisvisser jannisvisser commented Oct 30, 2024

AB#31025

Describe your changes

3 API-tests on switching chosen FSP

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have added tests wherever relevant
  • I have made sure that all automated checks pass before requesting a review
  • I do not need any deviation from our PR guidelines

@RubenGeo RubenGeo force-pushed the test.api-test-update-chosen-fsp branch from 03163f2 to 95cc2eb Compare October 31, 2024 12:00
@RubenGeo RubenGeo merged commit 862a1b8 into feat.refactor-registration-data Oct 31, 2024
0 of 5 checks passed
@RubenGeo RubenGeo deleted the test.api-test-update-chosen-fsp branch October 31, 2024 12:00
RubenGeo pushed a commit that referenced this pull request Nov 1, 2024
Excel FSP: multiple per program (#5848)

* Excel FSP: multiple per program

* Program registration attribute portal (#5858)

* Frontend alligning to new registration attribute & fsp config change

Renamed portal models according to new data structure, registration attribtes & new fsp conig

Added missing import

Check voucher support with fspName instead of label

* Styling changes

---------

Co-authored-by: Ruben <vandervalk@geoit.nl>

* Fix.excel setup (#5970)

* fix: get match column correctly AB#30281

* fix: lingering case of StatusEnum AB#30281

* fix: do not duplicate response rows with multiple fspConfigs

* fix: api-test AB#30281

* fix: fix and unskip api-test on get fsp instructions AB#30281

* fix: api-test on snapshot AB#30281

* feat: return separate template file per fsp config

* fix: snapshot template api test

* chore: remove hasReconciliation

* chore: split off interface

* fix: resolve comments

---------

Co-authored-by: Ruben <vandervalk@geoit.nl>
Co-authored-by: jannisvisser <jannisvisser@redcross.nl>

Validate fsp config and required attributes for Registration data refactor (#5860)

* AB#30474 Validate fsp config and required attributes WIP

* AB#30474 & AB#30781 Validate registration with program registration attribute refactor

* Migrate refactored registration data and program attributes (#5977)

Migrations refactor registration data

Co-authored-by: Ruben <vandervalk@geoit.nl>

* Select the right kind of type while migrating program questions

* Changes based on comments on the new validation of registrations

* Expect required fsp attributes to be filled during payment

* chore: rm unused methods / unskip tests / typos (#6004)

---------

Co-authored-by: Ruben <vandervalk@geoit.nl>
Co-authored-by: jannisvisser <jannisvisser@redcross.nl>

fix: make seed mock script work again (#6003)

* fix: make seed mock script work again

* fix: revert to abbreviated sequence name

test: api-tests on update chosen fsp AB#31025 (#6006)

Fix.test data (#6015)

* fix: api-test excel

* fix: make test data work

* fix: calculate totalmultiplierSum in dryRun case

* fix: import of boolean attribute
RubenGeo pushed a commit that referenced this pull request Nov 5, 2024
Excel FSP: multiple per program (#5848)

* Excel FSP: multiple per program

* Program registration attribute portal (#5858)

* Frontend alligning to new registration attribute & fsp config change

Renamed portal models according to new data structure, registration attribtes & new fsp conig

Added missing import

Check voucher support with fspName instead of label

* Styling changes

---------

Co-authored-by: Ruben <vandervalk@geoit.nl>

* Fix.excel setup (#5970)

* fix: get match column correctly AB#30281

* fix: lingering case of StatusEnum AB#30281

* fix: do not duplicate response rows with multiple fspConfigs

* fix: api-test AB#30281

* fix: fix and unskip api-test on get fsp instructions AB#30281

* fix: api-test on snapshot AB#30281

* feat: return separate template file per fsp config

* fix: snapshot template api test

* chore: remove hasReconciliation

* chore: split off interface

* fix: resolve comments

---------

Co-authored-by: Ruben <vandervalk@geoit.nl>
Co-authored-by: jannisvisser <jannisvisser@redcross.nl>

Validate fsp config and required attributes for Registration data refactor (#5860)

* AB#30474 Validate fsp config and required attributes WIP

* AB#30474 & AB#30781 Validate registration with program registration attribute refactor

* Migrate refactored registration data and program attributes (#5977)

Migrations refactor registration data

Co-authored-by: Ruben <vandervalk@geoit.nl>

* Select the right kind of type while migrating program questions

* Changes based on comments on the new validation of registrations

* Expect required fsp attributes to be filled during payment

* chore: rm unused methods / unskip tests / typos (#6004)

---------

Co-authored-by: Ruben <vandervalk@geoit.nl>
Co-authored-by: jannisvisser <jannisvisser@redcross.nl>

fix: make seed mock script work again (#6003)

* fix: make seed mock script work again

* fix: revert to abbreviated sequence name

test: api-tests on update chosen fsp AB#31025 (#6006)

Fix.test data (#6015)

* fix: api-test excel

* fix: make test data work

* fix: calculate totalmultiplierSum in dryRun case

* fix: import of boolean attribute

Program fsp configs endpoints (#5989)

* Some initial refactor and draft code

Add code framework for endpoints

Get endpoint implementation done

WIP implement post endpoint

* Manage fsp config enpoints

* Comments jannis manage program fsp config

---------

Co-authored-by: Diderik van Wingerden <diderik@diderikvanwingerden.com>
Co-authored-by: Ruben <vandervalk@geoit.nl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants