-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix duplicate columns in excel reconciliation service #6523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
Files not reviewed (1)
- services/121-service/test/payment/snapshots/do-payment-fsp-excel.test.ts.snap: Language not supported
diderikvw
previously approved these changes
Feb 18, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just 1 small suggestion!
services/121-service/test/payment/__snapshots__/do-payment-fsp-excel.test.ts.snap
Outdated
Show resolved
Hide resolved
b7a2791
to
8b9a11b
Compare
8b9a11b
to
612fc89
Compare
diderikvw
previously approved these changes
Feb 18, 2025
612fc89
to
98e54f9
Compare
7d00fa4
to
1081b07
Compare
0441532
to
76ec2f4
Compare
diderikvw
requested changes
Feb 20, 2025
services/121-service/test/payment/__snapshots__/do-payment-fsp-excel.test.ts.snap
Show resolved
Hide resolved
…-excel.test.ts.snap Co-authored-by: diderikvw <diderik@diderikvanwingerden.com>
Signed-off-by: Ruben <vandervalk@geoit.nl>
d924181
to
b2960a9
Compare
diderikvw
approved these changes
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AB#33631
Describe your changes
Checklist before requesting a review
Portalicious preview deployment
This PR does not have any preview deployments yet.