Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix duplicate columns in excel reconciliation service #6523

Merged
merged 6 commits into from
Feb 20, 2025

Conversation

RubenGeo
Copy link
Contributor

@RubenGeo RubenGeo commented Feb 17, 2025

AB#33631

Describe your changes

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have added tests wherever relevant
  • I have made sure that all automated checks pass before requesting a review
  • I do not need any deviation from our PR guidelines

Portalicious preview deployment

This PR does not have any preview deployments yet.

@RubenGeo RubenGeo added the bugfix Something that affects our end users is fixed label Feb 17, 2025
@Copilot Copilot bot review requested due to automatic review settings February 17, 2025 10:04

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.

Files not reviewed (1)
  • services/121-service/test/payment/snapshots/do-payment-fsp-excel.test.ts.snap: Language not supported
@RubenGeo RubenGeo enabled auto-merge (squash) February 17, 2025 10:07
diderikvw
diderikvw previously approved these changes Feb 18, 2025
Copy link
Contributor

@diderikvw diderikvw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just 1 small suggestion!

diderikvw
diderikvw previously approved these changes Feb 18, 2025
Ruben and others added 4 commits February 20, 2025 11:30
…-excel.test.ts.snap

Co-authored-by: diderikvw <diderik@diderikvanwingerden.com>
Signed-off-by: Ruben <vandervalk@geoit.nl>
@RubenGeo RubenGeo merged commit 13fc275 into main Feb 20, 2025
5 checks passed
@RubenGeo RubenGeo deleted the fix.excel-import-double-transactions branch February 20, 2025 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Something that affects our end users is fixed
Development

Successfully merging this pull request may close these issues.

2 participants