Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ignoreMissingKey option for values mapping #68

Merged
merged 2 commits into from
May 26, 2023
Merged

Conversation

abhidg
Copy link
Contributor

@abhidg abhidg commented May 25, 2023

No description provided.

@codecov-commenter
Copy link

Codecov Report

Merging #68 (acdfe9d) into main (c0309ee) will decrease coverage by 0.06%.
The diff coverage is 83.33%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main      #68      +/-   ##
==========================================
- Coverage   89.04%   88.98%   -0.06%     
==========================================
  Files           4        4              
  Lines         767      772       +5     
==========================================
+ Hits          683      687       +4     
- Misses         84       85       +1     
Impacted Files Coverage Δ
adtl/__init__.py 84.34% <80.00%> (-0.08%) ⬇️
tests/test_parser.py 100.00% <100.00%> (ø)

@abhidg abhidg requested a review from pipliggins May 26, 2023 09:37
Copy link
Collaborator

@pipliggins pipliggins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one comment on the specification description

docs/specification.md Show resolved Hide resolved
@abhidg abhidg merged commit 0a65601 into main May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants