Controller should return 204, not 201

globaldothealth · Jul 8, 2021 · 999e0a1 · 999e0a1
1 parent 8530f39
commit 999e0a1
Showing 1 changed file with 6 additions and 6 deletions.
diff --git a/verification/curator-service/api/src/controllers/sources.ts b/verification/curator-service/api/src/controllers/sources.ts
@@ -295,8 +295,8 @@ export default class SourcesController {
                     req.params.id
                 }&email=${encodeURIComponent(user.email)}`,
             );
-            if (response.status == 201) {
-                res.sendStatus(201).end();
+            if (response.status == 204) {
+                res.sendStatus(204).end();
             } else {
                 res.status(response.status).json(response.data);
             }
@@ -321,8 +321,8 @@ export default class SourcesController {
             const response = await axios.post(
                 `${this.dataServerURL}/api/cases/removePendingCases?sourceId=${req.params.id}`,
             );
-            if (response.status == 201) {
-                res.sendStatus(201).end();
+            if (response.status == 204) {
+                res.sendStatus(204).end();
             } else {
                 res.status(response.status).json(response.data);
             }
@@ -354,8 +354,8 @@ export default class SourcesController {
                     req.params.id
                 }&email=${encodeURIComponent(user.email)}`,
             );
-            if (response.status == 201) {
-                res.sendStatus(201).end();
+            if (response.status == 204) {
+                res.sendStatus(204).end();
             } else {
                 res.status(response.status).json(response.data);
             }