Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post error logs to Slack #1564

Closed
1 of 2 tasks
calremmel opened this issue Feb 16, 2021 · 2 comments
Closed
1 of 2 tasks

Post error logs to Slack #1564

calremmel opened this issue Feb 16, 2021 · 2 comments
Assignees
Labels
Importer P1: Launch blocker Needs fixing before we launch, schedule some time to investigate & fix
Milestone

Comments

@calremmel
Copy link
Contributor

calremmel commented Feb 16, 2021

The error log reporting function that relays ingestion function errors to Slack is currently broken. Presently, adding parser logs as triggers is a time-consuming manual process, and hard to maintain. Additionally, it only covers a few different cases of errors.

Proposed Solution

  • Wait until AWS Batch Migration is complete
  • Edit the lambda function to point to the Batch log group, which really will make things much simpler
@calremmel calremmel added P2: Nice to have This would be nice to have, if we have time we will fix it, if not good to launch and fix later when Importer labels Feb 16, 2021
@calremmel calremmel self-assigned this Feb 16, 2021
@calremmel
Copy link
Contributor Author

This should now wait on AWS Batch migration

@calremmel calremmel added this to the Post Launch milestone Mar 2, 2021
@joe-brilliant joe-brilliant added P1: Launch blocker Needs fixing before we launch, schedule some time to investigate & fix and removed P2: Nice to have This would be nice to have, if we have time we will fix it, if not good to launch and fix later when labels Mar 4, 2021
@calremmel calremmel removed their assignment Mar 5, 2021
@abhidg abhidg added P2: Nice to have This would be nice to have, if we have time we will fix it, if not good to launch and fix later when and removed P1: Launch blocker Needs fixing before we launch, schedule some time to investigate & fix labels Apr 20, 2021
@abhidg abhidg removed this from the Post Launch (Zoe) milestone Apr 20, 2021
@abhidg abhidg self-assigned this Jun 15, 2021
@abhidg abhidg added this to the Proxy milestone Sep 2, 2021
@joe-brilliant joe-brilliant modified the milestones: Proxy, Lewis Dec 7, 2021
@abhidg abhidg changed the title Rework error logs to slack function Post error logs to Slack Dec 15, 2021
@joe-brilliant joe-brilliant modified the milestones: Lewis, Holding Bin Feb 1, 2022
@abhidg abhidg modified the milestones: Holding Bin, Leonidas Feb 2, 2022
@abhidg abhidg added P1: Launch blocker Needs fixing before we launch, schedule some time to investigate & fix and removed P2: Nice to have This would be nice to have, if we have time we will fix it, if not good to launch and fix later when labels Feb 2, 2022
@abhidg
Copy link
Contributor

abhidg commented Feb 2, 2022

Raising to P1 to get more visibility on ingestion failures. Currently there's an error log posted to Slack via a e-mail hook but that is a JSON dump and not very readable

@iamleeg iamleeg self-assigned this Feb 28, 2022
iamleeg added a commit that referenced this issue Feb 28, 2022
iamleeg added a commit that referenced this issue Feb 28, 2022
Handle next token correctly

Handle slack rate limiting us
iamleeg added a commit that referenced this issue Feb 28, 2022
iamleeg added a commit that referenced this issue Mar 2, 2022
iamleeg added a commit that referenced this issue Mar 2, 2022
Handle next token correctly

Handle slack rate limiting us
iamleeg added a commit that referenced this issue Mar 2, 2022
iamleeg added a commit that referenced this issue Mar 2, 2022
@abhidg abhidg removed their assignment Mar 3, 2022
iamleeg added a commit that referenced this issue Mar 4, 2022
iamleeg added a commit that referenced this issue Mar 4, 2022
iamleeg added a commit that referenced this issue Mar 7, 2022
And define envs in Docker/CD action
iamleeg added a commit that referenced this issue Mar 7, 2022
iamleeg added a commit that referenced this issue Mar 7, 2022
And define envs in Docker/CD action
iamleeg added a commit that referenced this issue Mar 7, 2022
iamleeg added a commit that referenced this issue Mar 7, 2022
iamleeg added a commit that referenced this issue Mar 7, 2022
iamleeg added a commit that referenced this issue Mar 7, 2022
@iamleeg iamleeg closed this as completed Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Importer P1: Launch blocker Needs fixing before we launch, schedule some time to investigate & fix
Projects
None yet
Development

No branches or pull requests

4 participants