Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ingestion testing should use poetry #1991

Closed
iamleeg opened this issue Jul 8, 2021 · 1 comment
Closed

Ingestion testing should use poetry #1991

iamleeg opened this issue Jul 8, 2021 · 1 comment
Assignees
@iamleeg
Labels
P2: Nice to have This would be nice to have, if we have time we will fix it, if not good to launch and fix later when

Comments

@iamleeg
Copy link
Contributor

iamleeg commented Jul 8, 2021

Following on from #1918, the instructions to parser writers to test their parsers still tell them to use venv, even though the Docker infrastructure all uses poetry. This means potential for the two to get out of sync, and two sets of dependencies to monitor for security fixes. Let's go all-in on poetry.
@iamleeg iamleeg added the P2: Nice to have This would be nice to have, if we have time we will fix it, if not good to launch and fix later when label Jul 8, 2021
@iamleeg iamleeg mentioned this issue Jul 8, 2021
Merged
@iamleeg iamleeg self-assigned this Jul 19, 2021
iamleeg added a commit that referenced this issue Jul 20, 2021
@iamleeg
Document how to use poetry for the parser lib #1991
267c994
iamleeg added a commit that referenced this issue Jul 20, 2021
@iamleeg
Remove requirements.txt files as we use poetry pyproject.toml now #1991
106f21d
iamleeg added a commit that referenced this issue Jul 20, 2021
@iamleeg
Document how to use poetry for the parser lib #1991
3290159
iamleeg added a commit that referenced this issue Jul 20, 2021
@iamleeg
Remove requirements.txt files as we use poetry pyproject.toml now #1991
72ec929
@iamleeg
Copy link
Contributor Author

iamleeg commented Jul 20, 2021

It does use poetry; it just wasn't documented.

@iamleeg iamleeg closed this as completed Jul 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iamleeg iamleeg

Labels
P2: Nice to have This would be nice to have, if we have time we will fix it, if not good to launch and fix later when
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@iamleeg