Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove notes section for all countries, make available upon request #2673

Closed
iamleeg opened this issue Apr 19, 2022 · 2 comments
Closed

Remove notes section for all countries, make available upon request #2673

iamleeg opened this issue Apr 19, 2022 · 2 comments
Assignees
Labels
DPIA P0: Critical path blocker Blocking testing or the launch critical path, drop everything to investigate & fix
Milestone

Comments

@iamleeg
Copy link
Contributor

iamleeg commented Apr 19, 2022

The automatically-ingested notes contain free text that the upstream data providers added to the cases and these can be pretty specific and identifying, as the HDX partners have already discovered. Don't make notes part of the general data set, create a new 'note-viewer' role that has exclusive access and let admins give out (and revoke) that role as required.

@iamleeg iamleeg added this to the Devi milestone Apr 19, 2022
@iamleeg iamleeg added P0: Critical path blocker Blocking testing or the launch critical path, drop everything to investigate & fix DPIA labels Apr 19, 2022
@abhidg
Copy link
Contributor

abhidg commented Apr 20, 2022

There are two classes of notes -- A. ones added upstream, which I think we should just remove entirely, and B. generated during ingestion, to add information that is not captured by our schema, such as in https://github.com/globaldothealth/list/blob/main/ingestion/functions/parsing/colombia/colombia.py

At the moment, these are not disambiguated. We might want to treat these differently depending upon how useful these B.notes are.

@abhidg abhidg self-assigned this Apr 24, 2022
abhidg added a commit that referenced this issue Apr 25, 2022
abhidg added a commit that referenced this issue Apr 25, 2022
abhidg added a commit that referenced this issue Apr 25, 2022
abhidg added a commit that referenced this issue Apr 25, 2022
abhidg added a commit that referenced this issue Apr 27, 2022
abhidg added a commit that referenced this issue Apr 27, 2022
abhidg added a commit that referenced this issue Apr 27, 2022
abhidg added a commit that referenced this issue Apr 27, 2022
abhidg added a commit that referenced this issue Apr 27, 2022
abhidg added a commit that referenced this issue Apr 27, 2022
abhidg added a commit that referenced this issue Apr 29, 2022
abhidg added a commit that referenced this issue Apr 29, 2022
@joe-brilliant joe-brilliant modified the milestones: Devi, Agnes Apr 29, 2022
@joe-brilliant joe-brilliant modified the milestones: Agnes, Oberon Jun 7, 2022
@joe-brilliant
Copy link

Per @abhidg, done on main needs to be deployed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DPIA P0: Critical path blocker Blocking testing or the launch critical path, drop everything to investigate & fix
Projects
None yet
Development

No branches or pull requests

4 participants