Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1924 - Fixed gender filter #1925

Merged
merged 1 commit into from
Jun 10, 2021
Merged

1924 - Fixed gender filter #1925

merged 1 commit into from
Jun 10, 2021

Conversation

maciej-zarzeczny
Copy link
Contributor

Changes

  • Fixed gender filter

@codecov-commenter
Copy link

Codecov Report

Merging #1925 (d4a55b1) into main (7e46279) will increase coverage by 30.82%.
The diff coverage is 66.66%.

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #1925       +/-   ##
===========================================
+ Coverage   56.29%   87.11%   +30.82%     
===========================================
  Files          71       32       -39     
  Lines        2581      885     -1696     
  Branches      826      188      -638     
===========================================
- Hits         1453      771      -682     
+ Misses       1128      114     -1014     
Impacted Files Coverage Δ
data-serving/data-service/src/controllers/case.ts 80.26% <66.66%> (ø)
...ation/curator-service/ui/src/hooks/useDebounce.tsx
...on/curator-service/ui/src/components/StaticMap.tsx
...cation/curator-service/ui/src/components/Utils.tsx
...i/src/components/new-case-form-fields/Symptoms.tsx
...i/src/components/new-case-form-fields/NumCases.tsx
...omponents/new-case-form-fields/GenomeSequences.tsx
...urator-service/ui/src/components/LinelistTable.tsx
...ation/curator-service/ui/src/components/Charts.tsx
...onents/bulk-case-form-fields/CaptionedProgress.tsx
... and 94 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e46279...d4a55b1. Read the comment docs.

Copy link
Contributor

@sergioloporto sergioloporto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works great, good improvement

Copy link
Contributor

@abhidg abhidg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@abhidg abhidg merged commit fe507d4 into main Jun 10, 2021
@abhidg abhidg deleted the 1924-gender-filter-fix branch June 10, 2021 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants