Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disallowed colon #1931

Merged
merged 5 commits into from
Jun 30, 2021
Merged

disallowed colon #1931

merged 5 commits into from
Jun 30, 2021

Conversation

sergioloporto
Copy link
Contributor

Issie: #1893

@codecov-commenter
Copy link

codecov-commenter commented Jun 11, 2021

Codecov Report

Merging #1931 (08f4cd6) into main (e385196) will decrease coverage by 19.03%.
The diff coverage is 23.07%.

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #1931       +/-   ##
===========================================
- Coverage   75.62%   56.58%   -19.04%     
===========================================
  Files          24       76       +52     
  Lines         878     2626     +1748     
  Branches      138      836      +698     
===========================================
+ Hits          664     1486      +822     
- Misses        214     1140      +926     
Impacted Files Coverage Δ
...on/curator-service/ui/src/components/SearchBar.tsx 43.93% <23.07%> (ø)
...ation/curator-service/api/src/model/date-filter.ts
verification/curator-service/api/src/model/user.ts
...rator-service/api/src/clients/aws-events-client.ts
...ion/curator-service/api/src/controllers/uploads.ts
...ion/curator-service/api/src/controllers/sources.ts
...on/curator-service/api/src/model/upload-summary.ts
...tion/curator-service/api/src/util/assert-string.ts
...ation/curator-service/api/src/controllers/users.ts
verification/curator-service/api/src/index.ts
... and 91 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e385196...08f4cd6. Read the comment docs.

Copy link
Contributor

@maciej-zarzeczny maciej-zarzeczny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After pasting country:india into the search bar filters modal and error message appear, however after using some filters and searching the error message doesn't disappear (even though the search bar is already empty)

Screen Shot 2021-06-17 at 08 57 57

Copy link
Contributor

@maciej-zarzeczny maciej-zarzeczny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great! good job 💯

@sergioloporto sergioloporto requested a review from abhidg June 22, 2021 14:59
@abhidg abhidg merged commit 14f4ea6 into main Jun 30, 2021
@abhidg abhidg deleted the 1893-disable-colon-copy-paste branch June 30, 2021 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants