Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1921 delete and reimport sources without stable ids #1946

Merged
merged 14 commits into from
Jun 16, 2021

Conversation

iamleeg
Copy link
Contributor

@iamleeg iamleeg commented Jun 15, 2021

This is the backend work for #1921, the parser lib work will come in another PR (assuming we don't decide to move away from the data-service before that happens!).

@codecov-commenter
Copy link

codecov-commenter commented Jun 16, 2021

Codecov Report

Merging #1946 (d564962) into main (7e46279) will increase coverage by 10.34%.
The diff coverage is 80.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #1946       +/-   ##
===========================================
+ Coverage   56.29%   66.63%   +10.34%     
===========================================
  Files          71      132       +61     
  Lines        2581     4466     +1885     
  Branches      826     1174      +348     
===========================================
+ Hits         1453     2976     +1523     
- Misses       1128     1490      +362     
Impacted Files Coverage Δ
data-serving/data-service/src/model/case.ts 100.00% <ø> (ø)
...rification/curator-service/api/src/model/source.ts 100.00% <ø> (ø)
...or-service/ui/src/components/AutomatedBackfill.tsx 34.52% <ø> (ø)
...-service/ui/src/components/AutomatedSourceForm.tsx 44.00% <ø> (ø)
.../curator-service/ui/src/components/SourceTable.tsx 62.58% <60.00%> (-9.80%) ⬇️
...ion/curator-service/api/src/controllers/sources.ts 82.06% <72.34%> (ø)
...ce/ui/src/components/common-form-fields/Source.tsx 59.49% <75.00%> (+0.28%) ⬆️
data-serving/data-service/src/controllers/case.ts 80.46% <86.66%> (ø)
...rving/data-service/src/controllers/preprocessor.ts 100.00% <100.00%> (ø)
data-serving/data-service/src/index.ts 95.65% <100.00%> (ø)
... and 68 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e46279...d564962. Read the comment docs.

@abhidg
Copy link
Contributor

abhidg commented Jun 16, 2021

Looks good to me! Maybe we should have non-stable UUID as default, as that seems to be the majority of sources.

@iamleeg iamleeg merged commit 0bc1a9e into main Jun 16, 2021
@iamleeg iamleeg deleted the 1921_delete_and_reimport_sources_without_stable_ids branch June 16, 2021 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants