-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check in parser if the source has stable IDs and if not, delete the existing cases #1950
Conversation
Looks good, other than the default for hasStableIdentifiers which should be False as that's the case for majority. If a source actually has stable identifiers with hasStableIdentifiers, we are going to ingest the entire dataset needlessly, but it won't have incorrect data. |
@@ -41094,6 +40963,20 @@ | |||
"whatwg-fetch": "^3.0.0" | |||
} | |||
}, | |||
"react-beautiful-dnd": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this part of another PR? Seems to be from the highlighting search terms work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You know what? I don't know. I didn't explicitly put this here, I ran npm i
to ensure the deps were up to date and I committed the change to the lock file. I can't find react-beautiful-dnd
in the package.json so I can revert this file if you think it's wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, so the highlighting work seems to be already in main, which would explain this. I'm fine with keeping this change.
verification/curator-service/ui/src/components/ViewCase.tsx
30:import Highlighter from 'react-highlight-words'
@@ -41094,6 +40963,20 @@ | |||
"whatwg-fetch": "^3.0.0" | |||
} | |||
}, | |||
"react-beautiful-dnd": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, so the highlighting work seems to be already in main, which would explain this. I'm fine with keeping this change.
verification/curator-service/ui/src/components/ViewCase.tsx
30:import Highlighter from 'react-highlight-words'
Mostly putting this up as draft now as it's the easiest way to get the dockerised tests to run, which are the only way to test the function I need to change.
#1921