Replace print with logging where it makes sense #2319 #2525

iamleeg · 2022-02-15T21:10:24Z

No description provided.

ingestion/functions/common/common_lib.py

ingestion/functions/parsing/USA/USA.py

iamleeg added 5 commits February 15, 2022 21:09

Replace print with logging where it makes sense #2319

8cbdeaa

Correct use of logging in England parser #2319

df300f7

Replace logger.warn with logger.warning throughout #2319

6a5d9ff

Fix broken call to logger #2319

2c5fe56

Redirect logger to stdout in test #2319

593a53c

abhidg reviewed Feb 16, 2022

View reviewed changes

ingestion/functions/common/common_lib.py Outdated Show resolved Hide resolved

iamleeg added 2 commits February 16, 2022 13:34

define a local logging module to configure loggers uniformly #2319

21f9e8f

Use shared logger definition everywhere #2319

c648835

iamleeg requested review from abhidg and jim-sheldon February 16, 2022 13:48

iamleeg marked this pull request as ready for review February 16, 2022 13:48

iamleeg commented Feb 16, 2022

View reviewed changes

ingestion/functions/parsing/USA/USA.py Outdated Show resolved Hide resolved

abhidg approved these changes Feb 16, 2022

View reviewed changes

jim-sheldon approved these changes Feb 16, 2022

View reviewed changes

Test removal of import workaround. Tests still passed locally... #2319

889a1be

iamleeg force-pushed the 2319_replace_print_with_logging branch from 8568238 to 889a1be Compare February 16, 2022 14:23

Remove the imports hack in the rest of the parsers #2319

7dc4822

iamleeg merged commit 29ca1b4 into main Feb 16, 2022

iamleeg deleted the 2319_replace_print_with_logging branch February 16, 2022 15:02

Provide feedback