Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prune: move to Batch #2216 #2538

Merged
merged 1 commit into from
Feb 22, 2022
Merged

prune: move to Batch #2216 #2538

merged 1 commit into from
Feb 22, 2022

Conversation

abhidg
Copy link
Contributor

@abhidg abhidg commented Feb 21, 2022

No description provided.

@abhidg abhidg force-pushed the 2216-prune-batch branch 3 times, most recently from bb8ee2e to da28a11 Compare February 21, 2022 20:52
iamleeg
iamleeg suggested changes Feb 22, 2022
View reviewed changes
Copy link
Contributor

@iamleeg iamleeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look good, thanks Abhishek, just concerned that we'd be running main code in prod and nothing in dev.

data-serving/scripts/prune-uploads/Dockerfile
@@ -0,0 +1,9 @@
FROM python:3.10-slim
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3.10 😍

@iamleeg iamleeg self-requested a review February 22, 2022 13:50
@abhidg abhidg merged commit b91a488 into main Feb 22, 2022
@abhidg abhidg deleted the 2216-prune-batch branch February 22, 2022 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iamleeg iamleeg iamleeg approved these changes

@jim-sheldon jim-sheldon Awaiting requested review from jim-sheldon

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abhidg @iamleeg