Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated acknowledgment table #2586

Merged
merged 2 commits into from
Mar 15, 2022
Merged

Updated acknowledgment table #2586

merged 2 commits into from
Mar 15, 2022

Conversation

maciej-zarzeczny
Copy link
Contributor

Changes

  • Updated AcknowledgmentSource schema
  • Moved sorting and pagination logic from backend to frontend (this had to be done due to filtering out duplicated results on the frontend)
  • Updated tests

@codecov-commenter
Copy link

codecov-commenter commented Mar 15, 2022

Codecov Report

Merging #2586 (779974b) into main (f97ad98) will increase coverage by 2.06%.
The diff coverage is 30.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2586      +/-   ##
==========================================
+ Coverage   57.89%   59.95%   +2.06%     
==========================================
  Files          87      114      +27     
  Lines        3147     4358    +1211     
  Branches     1025     1238     +213     
==========================================
+ Hits         1822     2613     +791     
- Misses       1325     1745     +420     
Impacted Files Coverage Δ
.../components/AcknowledgmentsPage/helperFunctions.ts 0.00% <0.00%> (ø)
...ce/ui/src/components/AcknowledgmentsPage/index.tsx 0.00% <0.00%> (-1.67%) ⬇️
...rvice/ui/src/redux/acknowledgmentData/selectors.ts 60.00% <ø> (+4.44%) ⬆️
...r-service/ui/src/redux/acknowledgmentData/slice.ts 38.88% <0.00%> (+3.88%) ⬆️
...r-service/ui/src/redux/acknowledgmentData/thunk.ts 7.69% <0.00%> (-3.42%) ⬇️
...mponents/AcknowledgmentsPage/EnhancedTableHead.tsx 6.66% <6.66%> (ø)
...ion/curator-service/api/src/controllers/sources.ts 81.93% <33.33%> (ø)
...rification/curator-service/api/src/model/source.ts 95.00% <50.00%> (ø)
...ion/curator-service/api/src/controllers/geocode.ts 78.72% <82.14%> (ø)
verification/curator-service/api/src/index.ts 89.68% <100.00%> (ø)
... and 26 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d096007...779974b. Read the comment docs.

@abhidg abhidg merged commit 4efb442 into main Mar 15, 2022
@abhidg abhidg deleted the acknowledgment-table-updates branch March 15, 2022 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants