Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented UX changes for filter dialog #2594

Merged
merged 2 commits into from
Mar 17, 2022
Merged

Conversation

maciej-zarzeczny
Copy link
Contributor

Changes

  • Renamed FilterdModal -> FiltersDialog
  • Added UX sugestions (x icon, "Filter" -> "Apply", the ability to select None in Country dropdown)
  • Updated tests

@maciej-zarzeczny maciej-zarzeczny self-assigned this Mar 16, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #2594 (bf44888) into main (19ec386) will decrease coverage by 2.32%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2594      +/-   ##
==========================================
- Coverage   60.08%   57.76%   -2.33%     
==========================================
  Files         114       90      -24     
  Lines        4369     3170    -1199     
  Branches     1238     1031     -207     
==========================================
- Hits         2625     1831     -794     
+ Misses       1744     1339     -405     
Impacted Files Coverage Δ
...on/curator-service/ui/src/components/SearchBar.tsx 44.44% <ø> (ø)
...tor-service/ui/src/components/util/searchQuery.tsx 96.96% <ø> (ø)
...-service/ui/src/components/FiltersDialog/index.tsx 70.43% <100.00%> (ø)
...-service/ui/src/components/FiltersDialog/styled.ts 100.00% <100.00%> (ø)
...ion/curator-service/api/src/controllers/uploads.ts
...rification/curator-service/api/src/model/origin.ts
...erification/curator-service/api/src/util/logger.ts
verification/curator-service/api/src/model/user.ts
verification/curator-service/api/src/model/case.ts
...rator-service/api/src/clients/aws-lambda-client.ts
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19ec386...bf44888. Read the comment docs.

Copy link
Contributor

@iamleeg iamleeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you!

@abhidg abhidg merged commit 489d574 into main Mar 17, 2022
@abhidg abhidg deleted the 2504-filter-popup-changes branch March 17, 2022 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants