Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2670 bucket ages #2694

Merged
merged 4 commits into from
May 9, 2022
Merged

2670 bucket ages #2694

merged 4 commits into from
May 9, 2022

Conversation

iamleeg
Copy link
Contributor

@iamleeg iamleeg commented May 6, 2022

Remove age range from validator, add manual validation of age ranges in controller.

@iamleeg iamleeg requested review from abhidg and jim-sheldon May 6, 2022 15:37
@codecov-commenter
Copy link

codecov-commenter commented May 6, 2022

Codecov Report

Merging #2694 (e78a871) into main (985e8f4) will increase coverage by 1.15%.
The diff coverage is 91.30%.

@@            Coverage Diff             @@
##             main    #2694      +/-   ##
==========================================
+ Coverage   65.72%   66.87%   +1.15%     
==========================================
  Files         146      129      -17     
  Lines        5628     4447    -1181     
  Branches     1501     1316     -185     
==========================================
- Hits         3699     2974     -725     
+ Misses       1929     1473     -456     
Impacted Files Coverage Δ
data-serving/data-service/src/controllers/case.ts 82.50% <82.60%> (+0.18%) ⬆️
data-serving/data-service/src/model/case.ts 98.36% <100.00%> (+0.05%) ⬆️
...ata-serving/data-service/src/model/demographics.ts 100.00% <100.00%> (ø)
data-serving/data-service/src/util/case.ts 91.07% <100.00%> (+0.06%) ⬆️
verification/curator-service/api/src/index.ts
...cation/curator-service/api/src/controllers/auth.ts
...rification/curator-service/api/src/model/source.ts
...ation/curator-service/api/src/controllers/users.ts
verification/curator-service/api/src/model/case.ts
...erification/curator-service/api/src/model/token.ts
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 985e8f4...e78a871. Read the comment docs.

@iamleeg iamleeg merged commit e863141 into main May 9, 2022
@iamleeg iamleeg deleted the 2670_bucket_ages branch May 9, 2022 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants