Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2712 curator UI disease name #2730

Merged
merged 6 commits into from
Jun 15, 2022
Merged

2712 curator UI disease name #2730

merged 6 commits into from
Jun 15, 2022

Conversation

iamleeg
Copy link
Contributor

@iamleeg iamleeg commented Jun 15, 2022

I have parameterised the outbreak name in numerous places throughout the curator UI. Some notes:

  • I didn't do the Terms of Use, because they need updating anyway (see Updated TOU #2675) so it can be done then
  • The link on the profile page to /api-docs works in every environment except locally, because the UI and API are served on different ports in the local environment.

@codecov-commenter
Copy link

Codecov Report

Merging #2730 (c24283f) into main (4712973) will decrease coverage by 31.42%.
The diff coverage is 87.50%.

@@             Coverage Diff             @@
##             main    #2730       +/-   ##
===========================================
- Coverage   89.14%   57.72%   -31.43%     
===========================================
  Files          35       94       +59     
  Lines        1281     3229     +1948     
  Branches      295     1030      +735     
===========================================
+ Hits         1142     1864      +722     
- Misses        139     1365     +1226     
Impacted Files Coverage Δ
...on/curator-service/ui/src/components/App/index.tsx 85.82% <ø> (ø)
...ion/curator-service/ui/src/components/EditCase.tsx 80.00% <0.00%> (ø)
...tion/curator-service/ui/src/components/Profile.tsx 88.29% <ø> (ø)
...urator-service/ui/src/components/Sidebar/index.tsx 90.32% <ø> (ø)
...urator-service/ui/src/components/Sidebar/styled.ts 100.00% <ø> (ø)
...ion/curator-service/ui/src/components/CaseForm.tsx 14.53% <100.00%> (ø)
...ice/ui/src/components/landing-page/LandingPage.tsx 91.83% <100.00%> (ø)
...fication/curator-service/ui/src/constants/types.ts 100.00% <100.00%> (ø)
data-serving/data-service/src/model/date-range.ts
data-serving/data-service/src/model/location.ts
... and 126 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77e7bb7...c24283f. Read the comment docs.

@iamleeg iamleeg merged commit b510c16 into main Jun 15, 2022
@iamleeg iamleeg deleted the 2712_curator_ui_disease_name branch June 15, 2022 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants