Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the first filter terms (the only field in the schema at the moment is confirmation date, so the filter is for confirmation date). Some design notes:
to_mongo_query()
method to each type of filter. You could imagine that if we added a SQL store, it could add its ownto_sql_query()
methods allowing it to build aWHERE
clause.dateconfirmedbefore
/dateconfirmedafter
are the same as the existing data service.confirmation_date
for these searches to be efficient. I'm not doing indexes yet because there will be a lot of flux until the Day Zero schema is defined (and other decisions, like whether we use thelist:true
flag or some other mechanism for pseudo-atomic updates, are made). Currently a good option looks like pymong-migrate which could be embedded into this service so that on launch it migrates any indexes/validators it needs: open for discussion though!