Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix age parsing for New Zealand #2759

Merged
merged 2 commits into from
Jul 21, 2022
Merged

Fix age parsing for New Zealand #2759

merged 2 commits into from
Jul 21, 2022

Conversation

rbevansp
Copy link
Collaborator

fixes issue #2756

@rbevansp rbevansp requested a review from abhidg July 19, 2022 08:53
@@ -66,6 +66,8 @@ def convert_demographics(entry):
if (age := entry[_AGE]) != "NA":
if '90+' in age:
demo["ageRange"] = {"start": 90, "end": 120}
elif '70+' in age:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The upper age limit should be 120 unless it is mentioned in the data dictionary that this refers to 70-79.
Since there is already an entry for 90+, best to make this generic so that any N+ will give an age range of N to 120

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@abhidg the latest commit on [2756_nz_issue_fixup] branch has the requested change

@abhidg abhidg changed the title new_zealand.py Fix age parsing for New Zealand Jul 19, 2022
Copy link
Contributor

@abhidg abhidg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rbevansp!

@abhidg abhidg merged commit f9ad0b8 into main Jul 21, 2022
@abhidg abhidg deleted the 2756_nz_issue_fixup branch July 21, 2022 10:39
abhidg pushed a commit that referenced this pull request Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants