Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2623 Data acknowledgments are sorted case-insensitive #2774

Merged
merged 1 commit into from
Jul 21, 2022

Conversation

OskarKocjan
Copy link
Contributor

Changes:

  • Data acknowledgments are sorted case-insensitive

@codecov-commenter
Copy link

Codecov Report

Merging #2774 (4b19d74) into main (a9b141e) will decrease coverage by 5.32%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #2774      +/-   ##
==========================================
- Coverage   63.01%   57.69%   -5.33%     
==========================================
  Files          18       94      +76     
  Lines        1214     3231    +2017     
  Branches      187     1032     +845     
==========================================
+ Hits          765     1864    +1099     
- Misses        449     1367     +918     
Impacted Files Coverage Δ
.../components/AcknowledgmentsPage/helperFunctions.ts 0.00% <0.00%> (ø)
...cation/curator-service/api/src/controllers/auth.ts
...rator-service/api/src/clients/aws-lambda-client.ts
...erification/curator-service/api/src/model/token.ts
...fication/curator-service/api/src/model/database.ts
...n/curator-service/api/src/util/instance-details.ts
...on/curator-service/api/src/clients/email-client.ts
...ation/curator-service/api/src/util/validate-env.ts
...erification/curator-service/api/src/util/logger.ts
verification/curator-service/api/src/model/user.ts
... and 103 more

Copy link
Contributor

@maciej-zarzeczny maciej-zarzeczny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything works well 👍

@abhidg abhidg merged commit 49495ac into main Jul 21, 2022
@abhidg abhidg deleted the 2623-provider-name-sort-case-insensitive branch July 21, 2022 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants