2714 required fields #2776
Merged
2714 required fields #2776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Required fields must have a default value, to be applied to existing cases (which by definition have yet to receive a value for this now-required field
iamleeg
commented
Jul 20, 2022
| fields is a list of dataclass fields that should be added to the generated class. | ||
| field_models is a list of model objects describing the fields for the data dictionary | ||
| and for validation.""" | ||
| # FIXME generate the fields list from the field_models |
There was a problem hiding this comment.
my plan for this is when the day zero schema is committed, to create a list of Field objects that contain the day zero fields and get played into the Case class; then the logic for make_custom_case_class is simply to take a list of all known Fields and make data class fields for them. At that point I think the DayZeroCase intermediate class goes away.
jim-sheldon
approved these changes
Jul 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users can indicate that a custom field is required: this will change the validation rules such that a case is invalid if it doesn't provide a value for the specified field. As such, users must also supply an initial default value for the field, which will be applied to existing cases.