Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev: add RECAPTCHA environment variables #2897 #2908

Merged
merged 2 commits into from
Oct 17, 2022
Merged

Conversation

abhidg
Copy link
Contributor

@abhidg abhidg commented Oct 16, 2022

This fixes loading the portal when running locally, but does not affect the dev deployment, which is still broken. I checked the EKS deployment and it sets RECAPTCHA_SITE_KEY, which should be read by the curator service, but is not.

edit: Interestingly, if I change the REACT_APP_RECAPTCHA_SITE_KEY to RECAPTCHA_SITE_KEY everywhere, the portal does not work locally. Not sure why that is.

@codecov-commenter
Copy link

codecov-commenter commented Oct 16, 2022

Codecov Report

Merging #2908 (889a305) into main (aa9388c) will decrease coverage by 0.18%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #2908      +/-   ##
==========================================
- Coverage   60.51%   60.33%   -0.19%     
==========================================
  Files          21       21              
  Lines        1312     1316       +4     
  Branches      198      199       +1     
==========================================
  Hits          794      794              
- Misses        518      522       +4     
Impacted Files Coverage Δ
...cation/curator-service/api/src/controllers/auth.ts 44.41% <0.00%> (-0.48%) ⬇️
...ation/curator-service/api/src/controllers/cases.ts 48.17% <0.00%> (ø)
...ation/curator-service/api/src/controllers/users.ts 67.92% <ø> (ø)
verification/curator-service/api/src/model/user.ts 66.66% <ø> (ø)
...ervice/api/src/util/single-window-rate-limiters.ts 37.50% <ø> (ø)
...ation/curator-service/api/src/util/validate-env.ts 100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@maciej-zarzeczny maciej-zarzeczny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The REACT_APP prefix before env variables makes them accessible through process.env inside React apps. It basically tells React that those variables should be publicly accessible inside the app

@abhidg abhidg merged commit 93e2dc8 into main Oct 17, 2022
@abhidg abhidg deleted the 2897-fix-portal-loading branch October 17, 2022 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants