Add batchUpsert method to data service case API #680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamleeg
reviewed
Jul 30, 2020
khmoran
approved these changes
Jul 30, 2020
| res: Response, | ||
| ): Promise<void> => { | ||
| try { | ||
| const toBeUpsertedCaseIds = await findCaseIdsWithCaseReferenceData(req); |
There was a problem hiding this comment.
if this still isn't as fast as you want, in theory you could have this fn add the ids to the requests, so that below you don't have to re-filter? (assuming that's even an option in mongodb's bulkwrite fn)
There was a problem hiding this comment.
Meaning to perform the updateOne()'s specifying the _id, rather than the caseRef data pair?
I think that's a solid idea. I'm a little worried about this step being generally slow, but plan to test and make these kinds of tweaks in the subsequent change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Primary goal here is to make the bulk upsert MongoDB invocation more efficient.
In pursuit of avoiding a super large/dense PR, I'm cutting this at what's sort of an intermediate state. Rather than expose this endpoint directly in a subsequent PR, I'll probably wrap it together with the existing batchValidate method before doing so (in that same PR). Happy to hear thoughts on this.