Updated setup_package() and added new_author() function
#125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…entation template.
Family and given were not properly defined for the second author
… repo name (it assumes globalgov)
…packages() Will be iterated on a bit later on
…aming across packages
…e file is also added to new q packages
Still has a bug where one is unable to apply multiple elements to the comment vector. This is related to issue #91 of the desc package.
… function Added a TODO for the bug mentionned in issue #91 of the desc package
This reverts commit 43578f6.
And updated the documentation
…g as `create_local_package()` and updated tests for `setup_package()`, `import_data()` and `export_data()` New helper functions and tests are not currently working properly
…xport_data()` for now
…ing some of the previous functionality
jhollway
requested changes
Feb 22, 2021
…commented out some tests for now
jhollway
approved these changes
Feb 22, 2021
henriquesposito
changed the title
setup_packages() and added new_author() functionsetup_package() and added new_author() function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
These patch changes include updates to
setup_package()function to accept more than two package authors and ORCID numbers and the addition ofnew_author()function that adds new package contributors to package description file.Package
Collect
setup_package()to make it easier to set up collaborative qPackagessetup_package ()function accept more than two names and more than two authors #106 by makingsetup_package()accept more than two authors as argumentssetup_package()so that it sets up a license.md document in new q package #119 by updatingsetup_package()function so that it adds LICENSE file to new qPackagesnew_author()function #90 by adding anew_author()function that adds new package contributors to description fileCorrect
Connect
get_packages()to make it easier to install globalgov qPackagesget_packagesdoes not work according to vignette #117 by making theget_packages()work with package name only for qPackages part of the globalgov organizationget_packages()to accept listed number for package as argumentsdepends()#103 by adding GitHub lookup fordepends()functionChecklist: