-
Notifications
You must be signed in to change notification settings - Fork 603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: Add Contribution section #528
Conversation
@jquery/globalize, @kborchers, what do you think? More description at #474. |
It's missing to list the Globalize related projects. For example, cldr-data, external site and api docs, the integration projects (compiler, webpack plugin, react-globalize and its compiler and its webpack plugin) and ask contributors to include others. |
@@ -638,6 +640,53 @@ handle dependencies and CLDR loading manually yourself. | |||
[Read more...](doc/error/e-unsupported.md) | |||
|
|||
|
|||
## Contribution |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about "Contributing"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, "Contribution" is parallel with the subsequent section "Development". So, I think it sounds better in this context than "Contributing".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or you drop the "Development" header and make that part of "Contributing"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Leaving it as is for now, but we could definitely reevaluate and change it later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Re-read docs and I see "Getting started". So, I am changing "Contribution" to "Contributing" as you suggest.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
working on at this very moment. Priority is determined by the community needs. | ||
If there's anything you want to be done, feel free to weigh in on a new or | ||
existing issue or pull request. Pro activity is your best bet. | ||
- [Help wanted][] lists potential next work you could help us do now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something like this sound good: lists potential next work that you could help us to accomplish
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
87070b9 thx
The contribution section definitely needs a link to contributing.md. |
59363e5
to
5a72177
Compare
Absolutely. Included by 5a72177. |
@@ -1,4 +1,4 @@ | |||
Welcome! Thanks for your interest in contributing to Globalize. You're **almost** in the right place. More information on how to contribute to this and all other jQuery Foundation projects is over at [contribute.jquery.org](http://contribute.jquery.org). You'll definitely want to take a look at the articles on contributing [code](http://contribute.jquery.org/code). | |||
Welcome! Thanks for your interest in contributing to Globalize. You're **almost** in the right place. More information on how to contribute to this and all other jQuery Foundation projects is over at [contribute.jquery.org](http://contribute.jquery.org). To help you get started and before you jump into writing code, be sure to read [Writing Code for jQuery Foundation Projects](http://contribute.jquery.org/code/). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With this change, I wanted to emphasize one should get started with "Writing Code for jQuery Foundation Projects" article.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about something like this:
Before getting involved in and writing code for this project, be sure to read [...]'s section first.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Simpler 👍 changed by d07f68c
Fixes #474