Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Add Contribution section #528

Closed
wants to merge 29 commits into from
Closed

Docs: Add Contribution section #528

wants to merge 29 commits into from

Conversation

rxaviers
Copy link
Member

Fixes #474

@rxaviers rxaviers mentioned this pull request Oct 11, 2015
3 tasks
@rxaviers
Copy link
Member Author

@jquery/globalize, @kborchers, what do you think? More description at #474.

@rxaviers
Copy link
Member Author

It's missing to list the Globalize related projects. For example, cldr-data, external site and api docs, the integration projects (compiler, webpack plugin, react-globalize and its compiler and its webpack plugin) and ask contributors to include others.

@@ -638,6 +640,53 @@ handle dependencies and CLDR loading manually yourself.
[Read more...](doc/error/e-unsupported.md)


## Contribution
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about "Contributing"?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, "Contribution" is parallel with the subsequent section "Development". So, I think it sounds better in this context than "Contributing".

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or you drop the "Development" header and make that part of "Contributing"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leaving it as is for now, but we could definitely reevaluate and change it later.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-read docs and I see "Getting started". So, I am changing "Contribution" to "Contributing" as you suggest.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

working on at this very moment. Priority is determined by the community needs.
If there's anything you want to be done, feel free to weigh in on a new or
existing issue or pull request. Pro activity is your best bet.
- [Help wanted][] lists potential next work you could help us do now.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something like this sound good: lists potential next work that you could help us to accomplish

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

87070b9 thx

@scottgonzalez
Copy link
Contributor

The contribution section definitely needs a link to contributing.md.

@rxaviers
Copy link
Member Author

The contribution section definitely needs a link to contributing.md.

Absolutely. Included by 5a72177.

@@ -1,4 +1,4 @@
Welcome! Thanks for your interest in contributing to Globalize. You're **almost** in the right place. More information on how to contribute to this and all other jQuery Foundation projects is over at [contribute.jquery.org](http://contribute.jquery.org). You'll definitely want to take a look at the articles on contributing [code](http://contribute.jquery.org/code).
Welcome! Thanks for your interest in contributing to Globalize. You're **almost** in the right place. More information on how to contribute to this and all other jQuery Foundation projects is over at [contribute.jquery.org](http://contribute.jquery.org). To help you get started and before you jump into writing code, be sure to read [Writing Code for jQuery Foundation Projects](http://contribute.jquery.org/code/).
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With this change, I wanted to emphasize one should get started with "Writing Code for jQuery Foundation Projects" article.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about something like this:

Before getting involved in and writing code for this project, be sure to read [...]'s section first.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simpler 👍 changed by d07f68c

@rxaviers rxaviers closed this in edeab16 Oct 23, 2015
rxaviers added a commit that referenced this pull request Oct 24, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants