Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Date Parser: Improve timezone handling #693

Merged
merged 2 commits into from
Feb 23, 2017
Merged

Date Parser: Improve timezone handling #693

merged 2 commits into from
Feb 23, 2017

Conversation

rxaviers
Copy link
Member

  • Handle special case when target date and today date are in different DST rules;

Fixes #689

@jzaefferer
Copy link
Contributor

I guess the Travis test failure is due to wrong assumptions about system timezone?

@rxaviers
Copy link
Member Author

I guess the Travis test failure is due to wrong assumptions about system timezone?

Interesting enough to point out test changes. Thanks

@jzaefferer
Copy link
Contributor

Speaking of pointing out the status section: There's a conflict in test/unit/date/parse.js

@rxaviers
Test: Move FakeDate to util.js
439d9b9
@rxaviers
Date Parser: Improve timezone handling
315054c 
- Handle special case when target date and today date are in different
  DST rules;

Fixes globalizejs#689
@rxaviers rxaviers merged commit 315054c into globalizejs:master Feb 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rxaviers @jzaefferer