Date: Fix dateFormatter runtime #724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When dateToPartsFormatter was added, dateFormatter became an alias to it. Although globalize-compiler can handle it by using `.compileExtracts()`, it doesn't by using `.compile()` and passing `formattersAndParsers` argument. This update fixed that. Amends e4234a7 Ref globalizejs#678 Ref globalizejs#697 Ref globalizejs#700
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When dateToPartsFormatter was added, dateFormatter became an alias to
it. Although globalize-compiler can handle it by using
.compileExtracts(), it doesn't by using.compile()and passingformattersAndParsersargument. This update fixed that.Amends e4234a7
Ref #678
Ref #697
Ref #700