-
Notifications
You must be signed in to change notification settings - Fork 603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Number & Currency: Add format to parts support #891
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rxaviers
force-pushed
the
currency-to-parts
branch
from
March 20, 2020 18:26
dd7ee4d
to
058d167
Compare
rxaviers
commented
Mar 20, 2020
// ] | ||
``` | ||
|
||
[Read more...](doc/api/number/number-to-parts-formatter.md) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Add this file
rxaviers
force-pushed
the
currency-to-parts
branch
from
March 23, 2020 15:08
058d167
to
e30b498
Compare
|
rxaviers
force-pushed
the
currency-to-parts
branch
4 times, most recently
from
March 24, 2020 18:52
43c5d9d
to
fb8e4e2
Compare
rxaviers
commented
Mar 24, 2020
package.json
Outdated
@@ -75,7 +75,7 @@ | |||
"devDependencies": { | |||
"cldr-data-downloader": "^0.3.1", | |||
"glob": "^7.1.2", | |||
"globalize-compiler": "^0.3.0-alpha.6", | |||
"globalize-compiler": "globalizejs/globalize-compiler#support-number-currency-format-to-parts", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Use actual globalize-compiler release
rxaviers
force-pushed
the
currency-to-parts
branch
from
March 24, 2020 21:28
a6bf717
to
c4c0a56
Compare
rxaviers
force-pushed
the
currency-to-parts
branch
2 times, most recently
from
March 25, 2020 12:03
c493532
to
9f4efc5
Compare
- Currency: Fix code style - Currency: pluralGenerator better error handling Fixes globalizejs#679 Fixes globalizejs#680
rxaviers
force-pushed
the
currency-to-parts
branch
2 times, most recently
from
March 25, 2020 12:09
8347152
to
4afcb99
Compare
rxaviers
force-pushed
the
currency-to-parts
branch
from
March 25, 2020 12:15
4afcb99
to
a607631
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #679
Fixes #680