Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Number & Currency: Add format to parts support #891

Merged
merged 3 commits into from
Mar 25, 2020

Conversation

rxaviers
Copy link
Member

@rxaviers rxaviers commented Mar 20, 2020

  • Currency: Fix code style
  • Currency: pluralGenerator better error handling

Fixes #679
Fixes #680

// ]
```

[Read more...](doc/api/number/number-to-parts-formatter.md)
Copy link
Member Author

@rxaviers rxaviers Mar 20, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Add this file

@rxaviers
Copy link
Member Author

rxaviers commented Mar 23, 2020

  • Update README built sizes
  • Functional tests: add these new methods

@rxaviers rxaviers force-pushed the currency-to-parts branch 4 times, most recently from 43c5d9d to fb8e4e2 Compare March 24, 2020 18:52
package.json Outdated
@@ -75,7 +75,7 @@
"devDependencies": {
"cldr-data-downloader": "^0.3.1",
"glob": "^7.1.2",
"globalize-compiler": "^0.3.0-alpha.6",
"globalize-compiler": "globalizejs/globalize-compiler#support-number-currency-format-to-parts",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Use actual globalize-compiler release

- Currency: Fix code style
- Currency: pluralGenerator better error handling

Fixes globalizejs#679
Fixes globalizejs#680
@rxaviers rxaviers force-pushed the currency-to-parts branch 2 times, most recently from 8347152 to 4afcb99 Compare March 25, 2020 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Number format to parts Currency format to parts
1 participant