Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quoting with single quotes #1027

Merged
merged 18 commits into from
Aug 20, 2024
Merged

Quoting with single quotes #1027

merged 18 commits into from
Aug 20, 2024

Conversation

1313ou
Copy link
Contributor

@1313ou 1313ou commented Jul 5, 2024

Same as PR1026 with a different choice of quoting characters: single quotes with

‘ , u2018, single quotation, left/opening
’ , u2019, single quotation, right/closing

yielding:

‘quoted’

The exact rendering depends on the font but here is an enlarged screenshot:

single quotes

@jmccrae
Copy link
Member

jmccrae commented Aug 20, 2024

As there don't seem to be any other comments and this change looks the best, as the quotes are not doubled and they look in text as they should, I will accept this PR and close #1026 and #1028

@jmccrae jmccrae merged commit 80aef70 into globalwordnet:main Aug 20, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants