Feat/ps/backend #259
Merged
Feat/ps/backend #259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dasarathg68
reviewed
Jul 22, 2024
| </template> | ||
| <script setup lang="ts"> | ||
| import { ref, computed } from 'vue' | ||
| import IconPlus from '@/components/icons/IconPlus.vue' |
There was a problem hiding this comment.
Suggested change
| import IconPlus from '@/components/icons/IconPlus.vue' | |
| import { PlusCircleIcon } from '@heroicons/vue/24/outline' |
| :key="index" | ||
| class="collapse collapse-plus bg-base-200 border mt-2" | ||
| > | ||
| <input type="radio" name="my-accordion-3" /> |
There was a problem hiding this comment.
The accordions do not have the right behavior. (Does not toggle)
Use the AccordionComponent.vue component instead.
There was a problem hiding this comment.
Okay, I'll effect on a new request for the front-end
…system Merge "feature/permissioning-system" in "feat/PS/backend"
hermannleboss
requested changes
Jul 27, 2024
backend/prisma/schema.prisma
Outdated
There was a problem hiding this comment.
Here you don't have the same formatting. Try to uniform the formatting.
| import { prisma, errorResponse } from "../../utils"; | ||
| import { Request, Response } from "express"; | ||
|
|
||
| const initEntTypes = [ |
There was a problem hiding this comment.
Suggested change
| const initEntTypes = [ | |
| const initEntitlementTypes = [ |
You should name it in a way it's easy to understand.
|
Okay lemme work on implementing your reviews, I just wanted to get the functionality working first and then I'll handle authentication and securing the routes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Backend for the permissioning system.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
Checklist: