Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: tips feature #426

Merged
merged 5 commits into from
Nov 11, 2024
Merged

refactor: tips feature #426

merged 5 commits into from
Nov 11, 2024

Conversation

farrellh1
Copy link
Contributor

Description

Refactor tips feature

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

Make sure you run the following commands before submitting your PR:

  • /app
npm run build
npm run test:unit
npm run type-check
npm run lint
npm run format
  • /backend
npm run build
npm run test
npm run lint
npm run format
  • /contract
npm run test
npm run lint
npm run format
  • Please check if the PR fulfills these requirements

  • The commit message follows our guidelines

  • Tests for the changes have been added (for bug fixes/features)

@farrellh1 farrellh1 added the refactor code or file refactoring label Nov 10, 2024
@farrellh1 farrellh1 self-assigned this Nov 10, 2024
@hermannleboss hermannleboss linked an issue Nov 11, 2024 that may be closed by this pull request
1 task
Copy link

codecov bot commented Nov 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.84%. Comparing base (7a123a9) to head (cf5157d).
Report is 6 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #426   +/-   ##
========================================
  Coverage    67.84%   67.84%           
========================================
  Files          122      122           
  Lines         3844     3844           
  Branches      1198     1198           
========================================
  Hits          2608     2608           
  Misses         965      965           
  Partials       271      271           
Flag Coverage Δ
app-unit-tests 69.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@dasarathg68 dasarathg68 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Copy link
Contributor

@hermannleboss hermannleboss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hermannleboss hermannleboss merged commit db77aba into develop Nov 11, 2024
7 checks passed
@hermannleboss hermannleboss deleted the refactor/tips branch November 11, 2024 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor code or file refactoring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Refactor] Refactor Tip Using Wagmi
3 participants