Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: tips withdrawal amount #98

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

farrellh1
Copy link
Contributor

Description

We want the user can withdraw certain amount of the user's balance

Fixes # (#96)

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

Checklist:

  • Please check if the PR fulfills these requirements
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)

@farrellh1 farrellh1 added the enhancement New feature or request label May 12, 2024
@farrellh1 farrellh1 self-assigned this May 12, 2024
@farrellh1 farrellh1 marked this pull request as ready for review May 12, 2024 06:36
@farrellh1 farrellh1 linked an issue May 12, 2024 that may be closed by this pull request
Copy link
Contributor

@hermannleboss hermannleboss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to check some stuff on the upgradable contract

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we have to versioning the Contract we will deploy.
Looking for a better way to do it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i was thinking that we write some changes on the contract code and then after finish, we can deploy this new changes contract and then change the pointer of implementation contract to this contract

we dont have to create new file like TipsV2. unless there is major changes

contract/test/TipsProxyt.spec.ts Show resolved Hide resolved
@hermannleboss hermannleboss added this to the CNC Team Tips V2 milestone May 16, 2024
@hermannleboss hermannleboss removed this from the CNC Sprint Goal 2 milestone Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: choose amount to withdraw
2 participants