Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecatedになってたのでnode versionを上げる #38

Merged
merged 4 commits into from
Mar 22, 2024
+29 −17
Merged

deprecatedになってたのでnode versionを上げる #38

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5e74438
deprecatedになってたのでnode versionを上げる
imaharu Mar 22, 2024
8bb5b94
node version upでエラーが発生したライブラリをversion up
imaharu Mar 22, 2024
86bb954
feat: build all actions
github-actions[bot] Mar 22, 2024
1fc324d
GHAの結果が帰ってこないので再PUSH
imaharu Mar 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion aws-ssm-parameters/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,5 +6,5 @@ inputs:
description: Parameter keys and env var names (YAML)
required: true
runs:
using: 'node16'
using: 'node20'
main: 'dist/index.js'
2 changes: 1 addition & 1 deletion aws-ssm-parameters/dist/index.js.map
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion aws-ssm-parameters/dist/sourcemap-register.js
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion deploybot/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,5 +36,5 @@ inputs:
required: false
default: ''
runs:
using: 'node16'
using: 'node20'
main: 'dist/index.js'
2 changes: 1 addition & 1 deletion deploybot/dist/index.js.map
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion deploybot/dist/sourcemap-register.js
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion docker-image-tag/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,5 +10,5 @@ inputs:
required: false
default: auto
runs:
using: 'node16'
using: 'node20'
main: 'dist/index.js'
2 changes: 1 addition & 1 deletion docker-image-tag/dist/index.js.map
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion docker-image-tag/dist/sourcemap-register.js
View file
Open in desktop

Large diffs are not rendered by default.

6 changes: 3 additions & 3 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"private": true,
"main": "index.js",
"engines": {
"node": "16"
"node": "20"
},
"scripts": {
"format": "prettier --write '**/*.{js,ts}'",
Expand All @@ -26,8 +26,8 @@
"license": "MIT",
"devDependencies": {
"@types/jest": "^27.0.3",
"@types/node": "^17.0.2",
"@vercel/ncc": "^0.33.1",
"@types/node": "^20.11.30",
"@vercel/ncc": "^0.38.1",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

node version 上げたことによってエラーになったので version up

vercel/ncc#805

$ ncc build --source-map --license licenses.txt
Debugger listening on ws://127.0.0.1:59313/171ac505-aa1e-4395-8c52-1ff8d123cfc6
For help, see: https://nodejs.org/en/docs/inspector
Debugger attached.
ncc: Version 0.33.1
ncc: Compiling file index.js into CJS
Error: error:0308010C:digital envelope routines::unsupported
    at new Hash (node:internal/crypto/hash:68:19)
    at Object.createHash (node:crypto:138:10)
    at hashOf (/Users/ryohta.ochi/globis/sre-actions/node_modules/@vercel/ncc/dist/ncc/index.js.cache.js:37:1890023)
    at ncc (/Users/ryohta.ochi/globis/sre-actions/node_modules/@vercel/ncc/dist/ncc/index.js.cache.js:37:1894690)
    at runCmd (/Users/ryohta.ochi/globis/sre-actions/node_modules/@vercel/ncc/dist/ncc/cli.js.cache.js:1:52268)
    at 819 (/Users/ryohta.ochi/globis/sre-actions/node_modules/@vercel/ncc/dist/ncc/cli.js.cache.js:1:48838)
    at __webpack_require__ (/Users/ryohta.ochi/globis/sre-actions/node_modules/@vercel/ncc/dist/ncc/cli.js.cache.js:1:59076)
    at /Users/ryohta.ochi/globis/sre-actions/node_modules/@vercel/ncc/dist/ncc/cli.js.cache.js:1:59288
    at /Users/ryohta.ochi/globis/sre-actions/node_modules/@vercel/ncc/dist/ncc/cli.js.cache.js:1:59349
    at Object.<anonymous> (/Users/ryohta.ochi/globis/sre-actions/node_modules/@vercel/ncc/dist/ncc/cli.js:8:28) {
  opensslErrorStack: [ 'error:03000086:digital envelope routines::initialization error' ],
  library: 'digital envelope routines',
  reason: 'unsupported',
  code: 'ERR_OSSL_EVP_UNSUPPORTED'
}

"eslint": "^8.5.0",
"eslint-config-globis": "^1.3.1",
"eslint-plugin-jest": "^25.3.0",
Expand Down
22 changes: 17 additions & 5 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1477,7 +1477,7 @@
resolved "https://registry.yarnpkg.com/@types/json5/-/json5-0.0.29.tgz#ee28707ae94e11d2b827bcbe5270bcea7f3e71ee"
integrity sha1-7ihweulOEdK4J7y+UnC86n8+ce4=

"@types/node@*", "@types/node@^17.0.2":
"@types/node@*":
version "17.0.2"
resolved "https://registry.yarnpkg.com/@types/node/-/node-17.0.2.tgz#a4c07d47ff737e8ee7e586fe636ff0e1ddff070a"
integrity sha512-JepeIUPFDARgIs0zD/SKPgFsJEAF0X5/qO80llx59gOxFTboS9Amv3S+QfB7lqBId5sFXJ99BN0J6zFRvL9dDA==
Expand All @@ -1487,6 +1487,13 @@
resolved "https://registry.yarnpkg.com/@types/node/-/node-17.0.4.tgz#fec0ce0526abb6062fd206d72a642811b887a111"
integrity sha512-6xwbrW4JJiJLgF+zNypN5wr2ykM9/jHcL7rQ8fZe2vuftggjzZeRSM4OwRc6Xk8qWjwJ99qVHo/JgOGmomWRog==

"@types/node@^20.11.30":
version "20.11.30"
resolved "https://registry.yarnpkg.com/@types/node/-/node-20.11.30.tgz#9c33467fc23167a347e73834f788f4b9f399d66f"
integrity sha512-dHM6ZxwlmuZaRmUPfv1p+KrdD1Dci04FbdEm/9wEMouFqxYoFl5aMkt0VMAUtYRQDyYvD41WJLukhq/ha3YuTw==
dependencies:
undici-types "~5.26.4"

"@types/prettier@^2.1.5":
version "2.4.2"
resolved "https://registry.yarnpkg.com/@types/prettier/-/prettier-2.4.2.tgz#4c62fae93eb479660c3bd93f9d24d561597a8281"
Expand Down Expand Up @@ -1630,10 +1637,10 @@
"@typescript-eslint/types" "5.8.0"
eslint-visitor-keys "^3.0.0"

"@vercel/ncc@^0.33.1":
version "0.33.1"
resolved "https://registry.yarnpkg.com/@vercel/ncc/-/ncc-0.33.1.tgz#b240080a3c1ded9446a30955a06a79851bb38f71"
integrity sha512-Mlsps/P0PLZwsCFtSol23FGqT3FhBGb4B1AuGQ52JTAtXhak+b0Fh/4T55r0/SVQPeRiX9pNItOEHwakGPmZYA==
"@vercel/ncc@^0.38.1":
version "0.38.1"
resolved "https://registry.yarnpkg.com/@vercel/ncc/-/ncc-0.38.1.tgz#13f08738111e1d9e8a22fd6141f3590e54d9a60e"
integrity sha512-IBBb+iI2NLu4VQn3Vwldyi2QwaXt5+hTyh58ggAMoCGE6DJmPvwL3KPBWcJl1m9LYPChBLE980Jw+CS4Wokqxw==

abab@^2.0.3, abab@^2.0.5:
version "2.0.5"
Expand Down Expand Up @@ -4622,6 +4629,11 @@ unbox-primitive@^1.0.1:
has-symbols "^1.0.2"
which-boxed-primitive "^1.0.2"

undici-types@~5.26.4:
version "5.26.5"
resolved "https://registry.yarnpkg.com/undici-types/-/undici-types-5.26.5.tgz#bcd539893d00b56e964fd2657a4866b221a65617"
integrity sha512-JlCMO+ehdEIKqlFxk6IfVoAUVmgz7cU7zD/h9XZ0qzeosSHmUJVOzSQvvYSYWXkFXC+IfLKSIffhv0sVZup6pA==

universal-user-agent@^6.0.0:
version "6.0.0"
resolved "https://registry.yarnpkg.com/universal-user-agent/-/universal-user-agent-6.0.0.tgz#3381f8503b251c0d9cd21bc1de939ec9df5480ee"
Expand Down