Add new attributes on metrics register #10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main Changes
1. Context and Request ID
ContextRequestIDKey) and uses a safer name to avoid collisions.RequestID) is now public and used throughout the project.transport.goand in tests.2. Tests
httpclient_testpackage to follow the black box pattern.SetHostURLmethod inRequest.3. Request
SetHostURLmethod to theRequeststruct.Requestmethods.4. Metrics
registerMetricsfunction for better control of attributes and metric counters.5. Transport
RequestIDfunction when setting the request ID header.Other Adjustments