-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace --delete with --delete-destination-extra in transfer commands #1037
Conversation
7dfc257
to
53737cb
Compare
changelog.d/20241015_111820_max.tuecke_sc_35029_deprecate_delete_flag.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only minor restructured text markup issues in the changelog fragment.
changelog.d/20241015_111820_max.tuecke_sc_35029_deprecate_delete_flag.md
Outdated
Show resolved
Hide resolved
changelog.d/20241015_111820_max.tuecke_sc_35029_deprecate_delete_flag.md
Outdated
Show resolved
Hide resolved
changelog.d/20241015_111820_max.tuecke_sc_35029_deprecate_delete_flag.md
Outdated
Show resolved
Hide resolved
changelog.d/20241015_111820_max.tuecke_sc_35029_deprecate_delete_flag.md
Outdated
Show resolved
Hide resolved
FYI, I went ahead and pulled your changes and did a few manual tests. I received the deprecated warning as expected:
I was also able to create a timer with the new flag:
Plz, note that |
https://app.shortcut.com/globus/story/35029/globus-cli-replace-delete-with-delete-destination-extra-in-transfer-commands
Changes
--delete-destination-extra
flag toglobus timer create transfer
andglobus transfer
that mirrors the existing--delete
flags behavior--delete
flag forglobus timer create transfer
andglobus transfer
Testing
--delete
flag deprecation warning--delete
and--delete-destination-extra
are mutually exclusive